Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/node/paratime: Update config file for 23.0 #646

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

amela
Copy link
Member

@amela amela commented Nov 28, 2023

Migrated with oasis-node config migrate and updated variables.

@amela amela requested a review from kostko November 28, 2023 09:02
Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for trusting-archimedes-14c863 ready!

Name Link
🔨 Latest commit b36ae73
🔍 Latest deploy log https://app.netlify.com/sites/trusting-archimedes-14c863/deploys/6565c8b34565860008f3c268
😎 Deploy Preview https://deploy-preview-646--trusting-archimedes-14c863.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


# The following section is required for ParaTimes which are running inside the
# Intel SGX Trusted Execution Environment.
external_address: tcp://{{ external_address }}:26656
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you re-add the comments explaining some of the fields please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-added

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amela amela force-pushed the amela/update-paratime-config-for-23.0 branch from d20e4c5 to c3d9200 Compare November 28, 2023 10:49
@amela amela requested a review from ptrus November 28, 2023 10:53
# NOTE: You can add additional seed nodes to this list if you want.
seed:
- "{{ seed_node_address }}"
# The following section is required for ParaTimes which are running inside the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# The following section is required for ParaTimes which are running inside the
# The IAS section is required for ParaTimes which are running inside the

Or move the IAS section at the end, like it was before. Since currently it's not clear that "The following section" is ment only fort the "IAS" part.

@amela amela force-pushed the amela/update-paratime-config-for-23.0 branch from c3d9200 to c32a162 Compare November 28, 2023 10:59
@amela amela force-pushed the amela/update-paratime-config-for-23.0 branch from c32a162 to b36ae73 Compare November 28, 2023 11:02
@amela amela enabled auto-merge November 28, 2023 11:03
@amela amela merged commit ca9548c into main Nov 28, 2023
2 checks passed
@amela amela deleted the amela/update-paratime-config-for-23.0 branch November 28, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants